linux-kernel - Re: [PATCH] platform_driver_register: warn if probe is in .init.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y6jnw6qa.fsf@devron.myhome.or.jp>
Date:	Mon, 25 Jan 2010 06:09:01 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform_driver_register: warn if probe is in .init.text

Uwe Kleine-König <u.kleine-koenig@...gutronix.de> writes:

> +int platform_driver_register(struct platform_driver *drv)
> +{
> +	int ret = __platform_driver_register(drv);
> +
> +#if defined(CONFIG_HOTPLUG)
> +	/*
> +	 * drivers that are registered by platform_driver_register
> +	 * should not have their probe function in .init.text.  The
> +	 * reason is that a probe can happen after .init.text is
> +	 * discarded which then results in an oops.  The alternatives
> +	 * are using .devinit.text for the probe function or "register"
> +	 * with platform_driver_probe.
> +	 */
> +	if (drv->probe && kernel_init_text_address((unsigned long)drv->probe))
> +		pr_warning("oops-warning: probe function of platform driver %s"
> +			       " lives in .init.text\n", drv->driver.name);
> +#else
> +	/*
> +	 * without HOTPLUG probe functions can be discarded after the driver is
> +	 * loaded.
> +	 * There is a little chance for false positives, namely if the driver is
> +	 * registered after the .init sections are discarded.
> +	 */
> +	if (drv->probe && !kernel_init_text_address((unsigned long)drv->probe))
> +		pr_info("probably the probe function of platform driver %s can"
> +				" be moved to .init.text\n", drv->driver.name);
> +#endif
> +	return ret;
> +}

Um..., can't we extend modpost or such one for this? I think the static
analysis is better (assume the changing ->probe dynamically is really
rare).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/