linux-kernel - Re: [PATCH] - Fix unmap_vma() bug related to mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100125190052.GF5756@random.random>
Date:	Mon, 25 Jan 2010 20:00:52 +0100
From:	Andrea Arcangeli <aarcange@...hat.com>
To:	Jack Steiner <steiner@....com>
Cc:	mingo@...e.hu, tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] - Fix unmap_vma() bug related to mmu_notifiers

On Mon, Jan 25, 2010 at 11:45:56AM -0600, Jack Steiner wrote:
> unmap_vmas() can fail to correctly flush the TLB if a
> callout to mmu_notifier_invalidate_range_start() sleeps.

Not sure I understand: the callbacks invoked by
mmu_notifier_invalidate_range_start can't sleep, or rcu locking inside
mmu notifier will break too (first thing that should be replaced with
srcu if they were allowed to sleep).

In short there's no schedule that could be added because of those
callbacks so if this code isn't ok and schedules and screw on the
mmu_gather tlb it's probably not mmu notifier related.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/