[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <771cded01001260414q4c8df1e0k303772b87bc725eb@mail.gmail.com>
Date: Tue, 26 Jan 2010 07:14:14 -0500
From: Haojian Zhuang <haojian.zhuang@...il.com>
To: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@...mlogic.co.uk>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/01] regulator: support max8649
On Tue, Jan 26, 2010 at 7:00 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Tue, Jan 26, 2010 at 06:54:48AM -0500, Haojian Zhuang wrote:
>> On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown
>
>> > I'd expect the time taken to enable to be the voltage multipled by the
>> > step size rather than divided by the step size?
>
>> I don't agree at this point. The unit of step is uV/uSec. The function
>> should return uSec. So voltage divided by the step is more reasonable.
>
> Ah, then the variable step is confusingly named since it's actually a
> rate of change rather than a step size - I'd suggest rate or something
> like that instead.
>
update this patch.
Thanks
Haojian
View attachment "0001-regulator-enable-max8649-regulator-driver.patch" of type "text/x-patch" (13590 bytes)
Powered by blists - more mailing lists