linux-kernel - Re: [RFC/PATCH 1/5] usb: otg: add notifier support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201001260316.20529.david-b@pacbell.net>
Date:	Tue, 26 Jan 2010 03:16:20 -0800
From:	David Brownell <david-b@...bell.net>
To:	Felipe Balbi <felipe.balbi@...ia.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Grazvydas Ignotas <notasas@...il.com>,
	Madhusudhan Chikkature <madhu.cr@...com>,
	linux-omap@...r.kernel.org, "Greg Kroah-Hartman" <gregkh@...e.de>
Subject: Re: [RFC/PATCH 1/5] usb: otg: add notifier support

On Friday 11 December 2009, Felipe Balbi wrote:
> The notifier will be used to communicate usb events
> to other drivers like the charger chip.

Good idea ... but not OTG-specific.  It doesn't seem to me
that charging hookups belong in that header at all.

In fact, usb_gadget_vbus_draw() might better be implemented
as such a notifier call, removing that configuration mess
from the usb gadget drivers ("how can I know what charger
to use??").  That would be the most common situation:  a
peripheral-only device.

And in fact, OTG can be treated as a trivial superset of
peripheral-only USB.  (In terms of charger support, only!!)

I'd vote to convert all the USB-to-charger interfaces so
they use notifiers.  After fixing the events ... see
comments below.  :)


> This can be used as source of information to kick
> usb charger detection as described by the USB
> Battery Charging Specification 1.1 and/or to
> pass bMaxPower field of selected usb_configuration
> to charger chip in order to use that information
> as input current on the charging profile
> setup.
> 
> Signed-off-by: Felipe Balbi <felipe.balbi@...ia.com>
> ---
>  include/linux/usb/otg.h |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> index 52bb917..6c0b676 100644
> --- a/include/linux/usb/otg.h
> +++ b/include/linux/usb/otg.h
> @@ -9,6 +9,8 @@
>  #ifndef __LINUX_USB_OTG_H
>  #define __LINUX_USB_OTG_H
>  
> +#include <linux/notifier.h>
> +
>  /* OTG defines lots of enumeration states before device reset */
>  enum usb_otg_state {
>  	OTG_STATE_UNDEFINED = 0,
> @@ -33,6 +35,14 @@ enum usb_otg_state {
>  	OTG_STATE_A_VBUS_ERR,
>  };
>  
> +enum usb_xceiv_events {

Let's keep charger events separate from anything else,
like "enter host mode" or "enter peripheral mode" (or
even "disconnect").  The audiences for any other types
of event would be entirely different.

Right now there's a mess in terms of charger hookup,
so getting that straight is IMO a priority over any
other type of event.  Using events will decouple a
bunch of drivers, and simplify driver configuration.


> +	USB_EVENT_NONE,         /* no events or cable disconnected */
> +	USB_EVENT_VBUS,         /* vbus valid event */
> +	USB_EVENT_ID,           /* id was grounded */
> +	USB_EVENT_CHARGER,      /* usb dedicated charger */
> +	USB_EVENT_ENUMERATED,   /* gadget driver enumerated */

Those seem like the wrong events.  The right events for a charger
would be more along the lines of:

 - For peripheral:  "you may use N milliAmperes now".
 - General:  "Don't Charge" (a.k.a. "use 0 mA").

I don't see how "N" would be passed with those events ...

Haven't looked at the details of the charger spec, but
those two events are the *basics* from the USB 2.0 spec,
so "official" charger hardware wouldn't be less capable.

Thing like different levels of VBUS validity, ID grounding,
and so forth ... wouldn't be very relevant.  An OTG driver
will do various things, internally, when ID grounds; but
anything else is a function of what role eventually gets
negotiated.  And for the charger, they all add up to "Don't
Charge" (since ID grounded means A-role, sourcing power).

A host *might* want to be able to say things like "supply
up to N milliAmperes now", e.g. to let a regulator choose
the most efficient mode.


> +};
> +
>  #define USB_OTG_PULLUP_ID		(1 << 0)
>  #define USB_OTG_PULLDOWN_DP		(1 << 1)
>  #define USB_OTG_PULLDOWN_DM		(1 << 2)
> @@ -70,6 +80,9 @@ struct otg_transceiver {
>  	struct otg_io_access_ops	*io_ops;
>  	void __iomem			*io_priv;
>  
> +	/* for notification of usb_xceiv_events */
> +	struct blocking_notifier_head	notifier;

Why "blocking"?  That seems kind of unnatural; for example,
the main users -- like usb_gadget_vbus_draw() -- would be
called in IRQ context (blocking not allowed).

> +
>  	/* to pass extra port status to the root hub */
>  	u16			port_status;
>  	u16			port_change;
> @@ -203,6 +216,18 @@ otg_start_srp(struct otg_transceiver *otg)
>  	return otg->start_srp(otg);
>  }
>  
> +/* notifiers */
> +static inline int
> +otg_register_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
> +{
> +	return blocking_notifier_chain_register(&otg->notifier, nb);
> +}
> +
> +static inline void
> +otg_unregister_notifier(struct otg_transceiver *otg, struct notifier_block *nb)
> +{
> +	blocking_notifier_chain_unregister(&otg->notifier, nb);
> +}
>  
>  /* for OTG controller drivers (and maybe other stuff) */
>  extern int usb_bus_start_enum(struct usb_bus *bus, unsigned port_num);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/