linux-kernel - Re: [PATCH 1/2] cgroups: Fix to return errno in a failure path

Open Source and information security mailing list archives

Message-ID: <20100126145022.GA6224@us.ibm.com>
Date:	Tue, 26 Jan 2010 08:50:22 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"containers@...ts.osdl.org" <containers@...ts.osdl.org>,
	Paul Menage <menage@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] cgroups: Fix to return errno in a failure path

Quoting Li Zefan (lizf@...fujitsu.com):
> In cgroup_create(), if alloc_css_id() returns failure, the errno
> is not propagated to userspace, so mkdir will fail silently.
> 
> To trigger this bug, we mount blkio (or memory subsystem), and
> create more then 65534 cgroups. (The number of cgroups is limited
> to 65535 if a subsystem has use_id == 1)
> 
>  # mount -t cgroup -o blkio xxx /mnt
>  # for ((i = 0; i < 65534; i++)); do mkdir /mnt/$i; done
>  # mkdir /mnt/65534
>  (should return ENOSPC)
>  #
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Yup.

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
>  cgroup.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> --- a/kernel/cgroup.c.orig	2010-01-19 16:37:37.000000000 +0800
> +++ a/kernel/cgroup.c	2010-01-19 16:39:07.000000000 +0800
> @@ -3279,14 +3279,17 @@ static long cgroup_create(struct cgroup 
> 
>  	for_each_subsys(root, ss) {
>  		struct cgroup_subsys_state *css = ss->create(ss, cgrp);
> +
>  		if (IS_ERR(css)) {
>  			err = PTR_ERR(css);
>  			goto err_destroy;
>  		}
>  		init_cgroup_css(css, ss, cgrp);
> -		if (ss->use_id)
> -			if (alloc_css_id(ss, parent, cgrp))
> +		if (ss->use_id) {
> +			err = alloc_css_id(ss, parent, cgrp);
> +			if (err)
>  				goto err_destroy;
> +		}
>  		/* At error, ->destroy() callback has to free assigned ID. */
>  	}
> 
> _______________________________________________
> Containers mailing list
> Containers@...ts.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives