linux-kernel - Re: [PATCH 07/29] move efifb's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B5F164B.5070602@redhat.com>
Date:	Tue, 26 Jan 2010 11:20:27 -0500
From:	Peter Jones <pjones@...hat.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
CC:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Krzysztof Helt <krzysztof.h1@...zta.fm>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	Jaya Kumar <jayakumar.lkml@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chandramouli Narayanan <mouli@...ux.intel.com>,
	Huang Ying <ying.huang@...el.com>
Subject: Re: [PATCH 07/29] move efifb's probe function to .devinit.text

On 01/23/2010 03:35 PM, Uwe Kleine-König wrote:
> A pointer to efifb_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.

__devinit looks reasonable enough to me.

Acked-By: Peter Jones <pjones@...hat.com>

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Peter Jones <pjones@...hat.com>
> Cc: Krzysztof Helt <krzysztof.h1@...zta.fm>
> Cc: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
> Cc: Jaya Kumar <jayakumar.lkml@...il.com>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Maciej W. Rozycki <macro@...ux-mips.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Chandramouli Narayanan <mouli@...ux.intel.com>
> Cc: Huang Ying <ying.huang@...el.com>
> ---
>  drivers/video/efifb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index eb12182..2161f21 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -201,7 +201,7 @@ static int __init efifb_setup(char *options)
>  	return 0;
>  }
>  
> -static int __init efifb_probe(struct platform_device *dev)
> +static int __devinit efifb_probe(struct platform_device *dev)
>  {
>  	struct fb_info *info;
>  	int err;


-- 
        Peter

The trouble with the global village are all the global village idiots.
		-- Paul Ginsparg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/