[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100126171014.GA5999@himanshu-laptop>
Date: Tue, 26 Jan 2010 22:40:14 +0530
From: Himanshu Chauhan <hschauhan@...ltrace.org>
To: Greg KH <greg@...ah.com>
Cc: Himanshu Chauhan <himanshu@...metricore.com>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Kernel Newbies <kernelnewbies@...linux.org>
Subject: Re: sysfs_ops show vector: size of buffer not required?
On Tue, Jan 26, 2010 at 07:29:24AM -0800, Greg KH wrote:
> On Tue, Jan 26, 2010 at 12:01:27PM +0530, Himanshu Chauhan wrote:
> > On Mon, Jan 25, 2010 at 08:36:46PM -0800, Greg KH wrote:
> > > On Sun, Jan 24, 2010 at 01:11:18PM +0530, Himanshu Chauhan wrote:
> > > > Hi All,
> > > >
> > > > The sysfs_ops's show vector doesn't have a size of the
> > > > buffer given to the vector, while store on the other hand
> > > > has. What is the rationale behind it?
> > >
> > > If you need to check the size, you are doing something wrong.
> > >
> > > Seriously, that is the reason. A sysfs file should be a single value,
> > > which will never overflow the buffer.
> > >
> > I was talking in context of usb/ip's show_status. It writes a lot of data
> > into this buffer.
>
> Then it needs to be fixed. Again, it must be, one value per file, that
> is the sysfs rule.
>
> > Which seems to over flow the buffer. But anyways, I will check if it
> > can be reduced or at least be splitted into differnt device
> > attributes.
>
> That would be great.
Okay, I will do that.
>
> > BTW, Greg, Did you take a look at other patches I had sent? Are are worth or
> > I need rework?
>
> They are in my "to-apply" queue that I will be flushing out in the next
> few days.
Thanks Greg.
Regards
Himanshu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists