linux-kernel - Re: [PATCH 1/4] pci: Update pci_set_vga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Jan 2010 16:17:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Travis <travis@....com>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Ingo Molnar <mingo@...e.hu>, Russ Anderson <rja@....com>,
	Dave Airlie <airlied@...hat.com>, Alex Chiang <achiang@...com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Robin Holt <holt@....com>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Adam Jackson <ajax@...k.net>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Gaetan Nadon <memsize@...eotron.ca>,
	"H. Peter Anvin" <hpa@...or.com>,
	Aaron Plattner <aplattner@...dia.com>,
	Jack Steiner <steiner@....com>,
	Tiago Vignatti <tiago.vignatti@...ia.com>,
	Cliff Wickman <cpw@....com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	Christian Zander <chzander@...dia.com>,
	Yu Zhao <yu.zhao@...el.com>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 1/4] pci: Update pci_set_vga_state to call arch
 functions

On Mon, 25 Jan 2010 16:09:52 -0800
Mike Travis <travis@....com> wrote:

> > 
> > Still, a neater solution might be
> > 
> > int arch_pci_set_vga_state(...) __weak
> > {
> > 	return 0;
> > }
> > 
> > and then resolve it at linkage time?
> > 
> > 
> 
> Wouldn't the linked in stronger function then need to surround
> the UV register updating with "if (uv_system)"?

If the file which implements arch_pci_set_vga_state() is present in
vmlinux on non-uv systems then yes.

Presumably that file is arch/x86/kernel/apic/x2apic_uv_x.c, although
that might later become a problem if other sub-architectures a) want to
get at this hook and b) can be linked into vmlinux along with
arch/x86/kernel/apic/x2apic_uv_x.o.  But such a kernel wouldn't
actually link, so we'll need to address it at that stage.


If this is a UV-specific hack which other architectures and
sub-architectures are unlikely to need (seems that way?) then I'd be
going for something whcih is simple and minimal.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/