linux-kernel - Re: + drivers-block-floppyc-remove-used-once-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B600901.6090804@gmail.com>
Date:	Wed, 27 Jan 2010 10:36:01 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	linux-kernel@...r.kernel.org
CC:	akpm@...ux-foundation.org, mm-commits@...r.kernel.org,
	joe@...ches.com, bzolnier@...il.com, jens.axboe@...cle.com,
	marcin.slusarz@...il.com, shemminger@...tta.com
Subject: Re: + drivers-block-floppyc-remove-used-once-check_ready-macro.patch
 added to -mm tree

On 01/27/2010 01:37 AM, akpm@...ux-foundation.org wrote:
> Subject: drivers/block/floppy.c: remove used once CHECK_READY macro
> From: Joe Perches <joe@...ches.com>

That the macro is used once does not necessarily mean, it should be
removed. Please add more explanation to your changelogs. It should be
something like: "remove the macro as it is totally bogus in that it
changes control flow and we usually do not expect that". For example,
there were alerady few macro incidents in floppy that changed control
flow causing locking imbalances.

-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/