linux-kernel - Re: [PATCH] mx3fb: some debug and initialisation fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2010 10:45:21 +0100
From:	Alberto Panizzo <maramaopercheseimorto@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Sascha linux-arm <s.hauer@...gutronix.de>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Dan Williams <dan.j.williams@...el.com>,
	Krzysztof Helt <krzysztof.h1@...pl>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mx3fb: some debug and initialisation fixes.

On mar, 2010-01-26 at 13:46 -0800, Andrew Morton wrote:
> On Wed, 20 Jan 2010 15:57:14 +0100
> Alberto Panizzo <maramaopercheseimorto@...il.com> wrote:
> 
> > Fix the kernel oops when dev_dbg is called with mx3_fbi->txd == NULL
> > 
> > Fix the late initialisation of mx3fb->backlight_level.
> > If not, in the chain of function started by init_fb_chan(), in __blank() call 
> > sdc_set_brightness(mx3fb, mx3fb->backlight_level) that will shut down
> > the CONTRAST PWM output. 
> 
> I guess these aren't the biggest bugs we ever had but I tagged the
> patch for backporting into 2.6.32.x anyway - the fixes are prety
> obvious.

Yes, apart of the debug part, the late initialisation of 
mx3fb->backlight_level prevent screen switch-on on boot in my development
board. So for me (and for all hardware that make use of the CONTRAST PWM to
control the brightness) is important.

> 
> Your email client replaces tabs with spaces.  I fixed that up, but
> please do prevent it from happening next time. 
> Documentation/email-clients.txt has some Evolution tips.
> 

The Evolution client lose tabs in copy/past between mails....
I'll take more care on this in future.

Thanks!

Alberto!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/