linux-kernel - CBQ broken in 2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2010 11:05:47 +0000
From:	Anton Ivanov <anton.ivanov@...-begemot.co.uk>
To:	linux-kernel@...r.kernel.org
Subject: CBQ broken in 2.6

Hi list,

I have been looking at CBQ being broken in 2.6 (Debian BUG 534430).

The bug is very simple and it makes it unusable for all practical
purposes - BOUNDED classes always borrow from their parent. As a result
it impossible to:

1. Set and enforce a bandwidth limit to a class with a CBQ tree
2. Use CBQ to do QoS at any place but the actual link. For example - put
a linux box after behind a DSL modem and tell it to QoS at the bandwidth
at which the modem is configured.

I have now looked through the code of cbq_sched.c (in 2.6.33-rc5 and
2.6.26 as shipped by Debian).

In both pieces of code the variable in the class structure for CBQ
cl->borrow is used to signal if borrowing is allowed. If borrowing is
not allowed (BOUNDED class) it is set to NULL.

However the routine which parses the class options and defines the class
cbq_change_class() sets it to the parent class and never resets it to
NULL for bounded classes.

Am I missing something here? 

Please cc me as I am not subscribed to the list.

Best Regards,

-- 
   Understanding is a three-edged sword:
            your side, their side, and the truth. --Kosh Naranek

A. R. Ivanov
E-mail:  anton.ivanov@...-begemot.co.uk
WWW:     http://www.kot-begemot.co.uk/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/