linux-kernel - Re: [PATCH] tools/perf/perf.c: Clean up trivial style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2010 12:59:42 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	Thiago Farina <tfransosi@...il.com>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [PATCH] tools/perf/perf.c: Clean up trivial style issues.


* Arnaldo Carvalho de Melo <acme@...radead.org> wrote:

> Em Sun, Jan 24, 2010 at 06:21:46PM -0500, Thiago Farina escreveu:
> > Checked with:
> > ./../scripts/checkpatch.pl --terse --file perf.c
> > 
> > perf.c:51: ERROR: open brace '{' following function declarations go on the next line
> > perf.c:73: ERROR: "foo*** bar" should be "foo ***bar"
> > perf.c:112: ERROR: space prohibited before that close parenthesis ')'
> > perf.c:127: ERROR: space prohibited before that close parenthesis ')'
> > perf.c:171: ERROR: "foo** bar" should be "foo **bar"
> > perf.c:213: ERROR: "(foo*)" should be "(foo *)"
> > perf.c:216: ERROR: "(foo*)" should be "(foo *)"
> > perf.c:217: ERROR: space required before that '*' (ctx:OxV)
> > perf.c:452: ERROR: do not initialise statics to 0 or NULL
> > perf.c:453: ERROR: do not initialise statics to 0 or NULL
> 
> I'm ok with this, all comes from git lack of checkpatchin', from where
> this code was stolen^Wlifted, I guess :-)
> 
> Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Mind picking it up into your tree and sending it to me with your next series 
of patches?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/