linux-kernel - Re: [Stable-review] [20/98] atl1c:use common_task instead of reset_task and link_chg_task

Open Source and information security mailing list archives

Message-ID: <4B60516F.4020106@canonical.com>
Date:	Wed, 27 Jan 2010 15:45:03 +0100
From:	Stefan Bader <stefan.bader@...onical.com>
To:	Willy Tarreau <w@....eu>
CC:	Greg KH <gregkh@...e.de>, "David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, Jie Yang <jie.yang@...eros.com>,
	stable@...nel.org, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, stable-review@...nel.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [Stable-review] [20/98] atl1c:use common_task instead of	reset_task
 and link_chg_task

Willy Tarreau wrote:
> On Tue, Jan 26, 2010 at 03:33:46PM -0800, Greg KH wrote:
>> From: Jie Yang <jie.yang@...eros.com>
>>
>> commit cb19054697e92a793f336380fd72c588521178ff upstream.
>>
>> use common_task instead of reset_task and link_chg_task, so it fix "call cancel_work_sync
>> from the work itself".
>>
>> Signed-off-by: Jie Yang <jie.yang@...eros.com>
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> Cc: Ben Hutchings <ben@...adent.org.uk>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> I'm going to test this one. I'm randomly seeing my ASUS 1005HA
> hanging after I replug the network cable. I noticed that the
> driver from the Atheros site doesn't have the issue at all. I
> spent a week-end trying to eliminate almost all of the diffs
> between the two drivers to try to spot the faulty code chunk,
> until I realized that I went past the failure point without
> noticing in time because the issue was too much random :-(

Not sure how much this is true or helps. While looking over that patch I was
wondering whether there could be a problem of not having an explicit
cancel_work_sync on the way down. It just seems to disable actions by setting
the flags to 0 but I somehow it felt like it still could be scheduled to run
doing nothing...

-Stefan
> Clearly a non-bisectable issue. But with just this fix, I'll
> be able to tell if the problem is definitely over.
> 
> Regards,
> Willy
> 
> _______________________________________________
> Stable-review mailing list
> Stable-review@...ux.kernel.org
> http://linux.kernel.org/mailman/listinfo/stable-review

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives