linux-kernel - Re: + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1264603993.14552.71.camel@Joe-Laptop.home>
Date:	Wed, 27 Jan 2010 06:53:13 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mm-commits@...r.kernel.org, bzolnier@...il.com,
	jens.axboe@...cle.com, marcin.slusarz@...il.com,
	shemminger@...tta.com
Subject: Re: +
 drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to
 -mm tree

On Wed, 2010-01-27 at 10:43 +0100, Jiri Slaby wrote:
> On 01/27/2010 01:37 AM, akpm@...ux-foundation.org wrote:
> > @@ -3145,7 +3136,9 @@ static inline int raw_cmd_copyout(int cm
> > -		COPYOUT(*ptr);
> > +		ret = copy_to_user((void __user *)param, ptr, sizeof(*ptr));
> > +		if (ret)
> > +			return -EFAULT;
[]
> > -		COPYIN(*ptr);
> > +		ret = copy_from_user(ptr, (void __user *)param, sizeof(*ptr));
> 
> Actually the casts are not needed anymore, are they?

There's still some char/void silliness.
It certainly could be improved/removed.

Do feel free to submit patches with your
desired level of changelog prolixity.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/