linux-kernel - Re: [tip:x86/mce] x86, mce: Rename cpu_specific_poll to mce_cpu_specific

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B605617.6050006@redhat.com>
Date:	Wed, 27 Jan 2010 13:04:55 -0200
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	Borislav Petkov <petkovbb@...glemail.com>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	linux-tip-commits@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Fr??d??ric Weisbecker <fweisbec@...il.com>,
	Aristeu Rozanski <aris@...hat.com>,
	Doug Thompson <norsk5@...oo.com>,
	Huang Ying <ying.huang@...el.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [tip:x86/mce] x86, mce: Rename cpu_specific_poll to	mce_cpu_specific_poll

Andi Kleen wrote:
> it only covers
> parts of the space (some subset of Nehalems with a specific uncore). 

The changes for Xeon 55xx are minimal. I did some tests with the driver on it already.

> This does not include Xeon 75xx where all this is quite different.

I haven't the datasheets for 75xx, so I can't say for sure if it would be better to
use the same driver or to fork it.

>> I agree. The EDAC module handles memory errors for several memory controllers,
>> including some on non-x86 architectures. Letting this decode to happen outside
>> the kernel, just for a very few set of memory controllers, seems a bad idea.
> 
> Again you can't do all the things mcelog does in kernel space only.

Well, the error parsing can be done in kernel space in a standard way provided
by the edac interface.

I don't see why not the mcelog userspace shouldn't use the EDAC interface as one
of its source, getting memory errors from it, avoiding the need of re-parsing
the errors.

Cheers,
Mauro.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/