linux-kernel - Re: [PATCH 1/2] cgroups: Fix to return errno in a failure path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100127090531.546f8bea.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 27 Jan 2010 09:05:31 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Paul Menage <menage@...gle.com>
Cc:	Li Zefan <lizf@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"containers@...ts.osdl.org" <containers@...ts.osdl.org>
Subject: Re: [PATCH 1/2] cgroups: Fix to return errno in a failure path

On Tue, 26 Jan 2010 15:01:26 -0800
Paul Menage <menage@...gle.com> wrote:

> On Tue, Jan 26, 2010 at 12:16 AM, Li Zefan <lizf@...fujitsu.com> wrote:
> >
> > Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> 
> Acked-by: Paul Menage <menage@...gle.com>
> 
Thank you.

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

> > ---
> >  cgroup.c |    7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > --- a/kernel/cgroup.c.orig      2010-01-19 16:37:37.000000000 +0800
> > +++ a/kernel/cgroup.c   2010-01-19 16:39:07.000000000 +0800
> > @@ -3279,14 +3279,17 @@ static long cgroup_create(struct cgroup
> >
> >        for_each_subsys(root, ss) {
> >                struct cgroup_subsys_state *css = ss->create(ss, cgrp);
> > +
> >                if (IS_ERR(css)) {
> >                        err = PTR_ERR(css);
> >                        goto err_destroy;
> >                }
> >                init_cgroup_css(css, ss, cgrp);
> > -               if (ss->use_id)
> > -                       if (alloc_css_id(ss, parent, cgrp))
> > +               if (ss->use_id) {
> > +                       err = alloc_css_id(ss, parent, cgrp);
> > +                       if (err)
> >                                goto err_destroy;
> > +               }
> >                /* At error, ->destroy() callback has to free assigned ID. */
> >        }
> >
> >
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/