linux-kernel - Re: [RFC PATCH 5/5] gic: initialize interrupts as per argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100127232955.GG29665@n2100.arm.linux.org.uk>
Date:	Wed, 27 Jan 2010 23:29:55 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	adharmap@...eaurora.org
Cc:	linux-arm-kernel@...ts.infradead.org, Ingo Molnar <mingo@...e.hu>,
	Catalin Marinas <catalin.marinas@....com>,
	Yinghai Lu <yinghai@...nel.org>,
	Tony Lindgren <tony@...mide.com>,
	Santosh Shilimkar <santosh.shilimkar@...com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Kalle Valo <kalle.valo@....fi>, Jean Pihet <jpihet@...sta.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Colin Tuckley <colin.tuckley@....com>,
	Philby John <pjohn@...mvista.com>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Alessandro Rubini <rubini@...pv.it>,
	Andrea Gallo <andrea.gallo@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Abhijeet Dharmapurikar <adharmap@...cinc.com>
Subject: Re: [RFC PATCH 5/5] gic: initialize interrupts as per argument

On Wed, Jan 27, 2010 at 11:32:29AM -0800, adharmap@...eaurora.org wrote:
> From: Abhijeet Dharmapurikar <adharmap@...cinc.com>
> 
> Initialize interrupts as per an argument passed instead of initializing
> them as active level low triggered interrupts.
> 
> Signed-off-by: Abhijeet Dharmapurikar <adharmap@...cinc.com>
> ---
>  Configuring level triggered interrupts as default may not be correct on
>  some platforms, this changes the default behaviour of the gic_dist_init 
>  function and also adds a flag to indicate whether the default should be level
>  or edge.

Changing the interrupt type for all interrupts is just wrong.  For on-chip
peripherals, you generally want to use level based interrupts as they're
the most efficient and simplest way to signal interrupts.

It should be a per-interrupt thing, and we already have that through
request_irq() etc.  Other platforms manage this just fine without having
to have special configuration like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/