linux-kernel - Re: [PATCH] imxfb: correct location of callbacks in suspend and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100127154818.de91e255.akpm@linux-foundation.org>
Date:	Wed, 27 Jan 2010 15:48:18 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
	trivial@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] imxfb: correct location of callbacks in suspend and
 resume

On Mon, 25 Jan 2010 16:37:34 +0100
Uwe Kleine-K__nig  <u.kleine-koenig@...gutronix.de> wrote:

> The probe function passes a pointer to a struct fb_info to
> platform_set_drvdata, so don't interpret the return value of
> platform_get_drvdata as a pointer to struct imxfb_info.
> 
> Signed-off-by: Uwe Kleine-K__nig <u.kleine-koenig@...gutronix.de>
> Acked-by: Sascha Hauer <kernel@...gutronix.de>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
>  drivers/video/imxfb.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c
> index 66358fa..b4b6dec 100644
> --- a/drivers/video/imxfb.c
> +++ b/drivers/video/imxfb.c
> @@ -593,7 +593,8 @@ static int imxfb_activate_var(struct fb_var_screeninfo *var, struct fb_info *inf
>   */
>  static int imxfb_suspend(struct platform_device *dev, pm_message_t state)
>  {
> -	struct imxfb_info *fbi = platform_get_drvdata(dev);
> +	struct fb_info *info = platform_get_drvdata(dev);
> +	struct imxfb_info *fbi = info->par;
>  
>  	pr_debug("%s\n", __func__);
>  
> @@ -603,7 +604,8 @@ static int imxfb_suspend(struct platform_device *dev, pm_message_t state)
>  
>  static int imxfb_resume(struct platform_device *dev)
>  {
> -	struct imxfb_info *fbi = platform_get_drvdata(dev);
> +	struct fb_info *info = platform_get_drvdata(dev);
> +	struct imxfb_info *fbi = info->par;
>  
>  	pr_debug("%s\n", __func__);
>  

What were the runtime effects of this bug?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/