linux-kernel - Re: [PATCH] Generic PS/2 mouse detected on Fujitsu Lifebook B-Series model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100127155514.cc743fa4.akpm@linux-foundation.org>
Date:	Wed, 27 Jan 2010 15:55:14 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	jon - <crayzeejon@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Dmitry Torokhov <dtor@...l.ru>
Subject: Re: [PATCH] Generic PS/2 mouse detected on Fujitsu Lifebook
 B-Series  model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen

(suitable cc's added)

On Mon, 25 Jan 2010 16:12:43 +0000
jon - <crayzeejon@...il.com> wrote:

> From: Jon Dodgson <crayzeejon@...il.com>
> 
> Fix Detection of Lifebook B-Series Laptop touch screen with DMI
> product Name string 'Lifebook B Series'
> 
> Signed-off-by: Jon Dodgson <crayzeejon@...il.com>
> 
> ---
> diff -Nurb linux-2.6.26.2/drivers/input/mouse/lifebook.c
> linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c
> --- linux-2.6.26.2/drivers/input/mouse/lifebook.c    2008-08-06
> 17:19:01.000000000 +0100
> +++ linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c    2010-01-25
> 02:56:41.000000000 +0000
> @@ -51,6 +51,12 @@
>     {
>         .ident = "LifeBook B",
>         .matches = {
> +            DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"),
> +        },
> +    },
> +    {
> +        .ident = "LifeBook B",
> +        .matches = {
>             DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"),
>         },
>     },

So the problem is "LifeBook" versus "Lifebook"?  These matches are
case-sensitive?

I don't know what kernel you were patching, but current kernels no
longer have the ".ident" initialisation in that table.  If it _was_
still there then I'd wonder why you set the ident to "LifeBook B"
rather than "Lifebook B".

Your email client wordwrapped the patch and replaced its tabs with
spaces.

Anyway, thanks.  Please work this with Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/