linux-kernel - Re: [PATCH] fs/binfmt_elf.c: fix a do-while statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100126180752.951509b5.akpm@linux-foundation.org>
Date:	Tue, 26 Jan 2010 18:07:52 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Roland McGrath <roland@...hat.com>,
	WANG Cong <amwang@...hat.com>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf.c: fix a do-while statement.

On Tue, 26 Jan 2010 23:44:29 -0200 Thiago Farina <tfransosi@...il.com> wrote:

> > It is somewhat unconventional coding style and it'd be good if
> > checkpatch were to warn so that we don't _add_ such things to the tree.
> >
> > But IMO it's such a minor thing that once it _is_ in the tree, it's not
> > really worth the patch noise to go and fix it up.
> 
> Yeah, much noise for a small thing. I will not fix more warnings like
> this in future.

I'd be OK with fixing things like this as part of a larger
"fs/binfmt_elf.c: coding-style fixes" or "fs/*elf.c: ...", etc.  One
big hit.  It's the little dribble of one-line fixes which I'd prefer to
avoid.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/