lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jan 2010 00:54:49 -0800 (PST) From: David Rientjes <rientjes@...gle.com> To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> cc: Andrew Morton <akpm@...ux-foundation.org>, Balbir Singh <balbir@...ux.vnet.ibm.com>, minchan.kim@...il.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH v4 1/2] sysctl clean up vm related variable declarations On Wed, 27 Jan 2010, KAMEZAWA Hiroyuki wrote: > Now, there are many "extern" declaration in kernel/sysctl.c. "extern" > declaration in *.c file is not appreciated in general. > And Hmm...it seems there are a few redundant declarations. > sysctl_overcommit_memory and sysctl_overcommit_ratio, right? > Because most of sysctl variables are defined in its own header file, > they should be declared in the same style, be done in its own *.h file. > > This patch removes some VM(memory management) related sysctl's > variable declaration from kernel/sysctl.c and move them to > proper places. > > Change log: > - 2010/01/27 (new) > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> This is a very nice cleanup of the sysctl code, I hope you find the time to push it regardless of the future direction of the oom killer lowmem constraint. One comment below. > --- > include/linux/mm.h | 5 +++++ > include/linux/mmzone.h | 1 + > include/linux/oom.h | 5 +++++ > kernel/sysctl.c | 16 ++-------------- > mm/mmap.c | 5 +++++ > 5 files changed, 18 insertions(+), 14 deletions(-) > > Index: mmotm-2.6.33-Jan15-2/include/linux/mm.h > =================================================================== > --- mmotm-2.6.33-Jan15-2.orig/include/linux/mm.h > +++ mmotm-2.6.33-Jan15-2/include/linux/mm.h > @@ -1432,6 +1432,7 @@ int in_gate_area_no_task(unsigned long a > #define in_gate_area(task, addr) ({(void)task; in_gate_area_no_task(addr);}) > #endif /* __HAVE_ARCH_GATE_AREA */ > > +extern int sysctl_drop_caches; > int drop_caches_sysctl_handler(struct ctl_table *, int, > void __user *, size_t *, loff_t *); > unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask, > @@ -1476,5 +1477,9 @@ extern int soft_offline_page(struct page > > extern void dump_page(struct page *page); > > +#ifndef CONFIG_NOMMU > +extern int sysctl_nr_trim_pages; This should be #ifndef CONFIG_MMU. > +#endif > + > #endif /* __KERNEL__ */ > #endif /* _LINUX_MM_H */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists