linux-kernel - Re: [alsa-devel] [PATCH]Change the AZX_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hy6jiiono.wl%tiwai@suse.de>
Date:	Thu, 28 Jan 2010 10:06:51 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Jaroslav Kysela <perex@...ex.cz>
Cc:	Wei Ni <wni@...dia.com>, 'akpm' <akpm@...ux-foundation.org>,
	'alsa-devel' <alsa-devel@...a-project.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'Pavel Hofman' <pavel.hofman@...ite.cz>
Subject: Re: [alsa-devel]  [PATCH]Change the AZX_MAX_PCMS to 10

At Thu, 28 Jan 2010 09:48:44 +0100 (CET),
Jaroslav Kysela wrote:
> 
> On Thu, 28 Jan 2010, Wei Ni wrote:
> 
> > Hi, Takashi When I develop hdmi audio driver on the GT21x, I found a bug 
> > in the had_intel.c In hda_codec.c, it has define "[HDA_PCM_TYPE_HDMI] = 
> > { 3, 7, 8, 9, -1 },", it support up to device 9 for HDMI. But in 
> > hda_intel.c, it only define AZX_MAX_PCMS as 8. So the GT21x have 4 hdmi 
> > codecs, when run azx_attach_pcm_stream(), it will show error "Invalid 
> > PCM device number 8", and "... number 9", and return "-EINVAL". We 
> > should change the AZX_MAX_PCMS to 10.
> 
> I'm afraid, but having more than 8 PCM devices might cause problems when 
> CONFIG_SND_DYNAMIC_MINORS is not set. At least, this condition 
> (#if SNDRV_PCM_DEVICES < 10) should be handled in the HDA driver.

Indeed.  But it'll be give anyway at runtime, so no big issue.

The fix, however, should be merged because of inconsistency between
hda_intel.c and hda_codec.c.  We should put this rather in
hda_codec.h so that it can be referred from both.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/