linux-kernel - [GIT PULL] hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1264689172-9077-1-git-send-regression-fweisbec@gmail.com>
Date:	Thu, 28 Jan 2010 15:32:52 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	"K. Prasad" <prasad@...ux.vnet.ibm.com>,
	Maneesh Soni <maneesh@...ibm.com>
Subject: [GIT PULL] hw_breakpoint fix

Ingo,

Please pull the perf/urgent branch that can be found at:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
	perf/urgent

Thanks,
	Frederic
---

Mahesh Salgaonkar (1):
      hw_breakpoints: Release the bp slot if arch_validate_hwbkpt_settings() fails.


 kernel/hw_breakpoint.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

---
commit b23ff0e9330e4b11e18af984d50573598e10e7f9
Author: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>
Date:   Thu Jan 21 18:25:16 2010 +0530

    hw_breakpoints: Release the bp slot if arch_validate_hwbkpt_settings() fails.
    
    On a given architecture, when hardware breakpoint registration fails
    due to un-supported access type (read/write/execute), we lose the bp
    slot since register_perf_hw_breakpoint() does not release the bp slot
    on failure.
    Hence, any subsequent hardware breakpoint registration starts failing
    with 'no space left on device' error.
    
    This patch introduces error handling in register_perf_hw_breakpoint()
    function and releases bp slot on error.
    
    Signed-off-by: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>
    Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>
    Cc: K. Prasad <prasad@...ux.vnet.ibm.com>
    Cc: Maneesh Soni <maneesh@...ibm.com>
    LKML-Reference: <20100121125516.GA32521@...ibm.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>

diff --git a/kernel/hw_breakpoint.c b/kernel/hw_breakpoint.c
index 50dbd59..c030ae6 100644
--- a/kernel/hw_breakpoint.c
+++ b/kernel/hw_breakpoint.c
@@ -296,6 +296,10 @@ int register_perf_hw_breakpoint(struct perf_event *bp)
 	if (!bp->attr.disabled || !bp->overflow_handler)
 		ret = arch_validate_hwbkpt_settings(bp, bp->ctx->task);
 
+	/* if arch_validate_hwbkpt_settings() fails then release bp slot */
+	if (ret)
+		release_bp_slot(bp);
+
 	return ret;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/