linux-kernel - Re: [PATCH] drm/i915: Selectively enable self-reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.u689ajucasvm2a@kedge>
Date:	Thu, 28 Jan 2010 19:21:47 +0100
From:	"Roman Jarosz" <kedgedev@...il.com>
To:	"Michael Reinelt" <michael@...nelt.co.at>,
	"Pekka Enberg" <penberg@...helsinki.fi>
Cc:	"Chris Wilson" <chris@...is-wilson.co.uk>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"A Rojas" <nqn1976list@...il.com>,
	"A. Boulan" <arnaud.boulan@...ertysurf.fr>,
	jcnengel@...glemail.com, rientjes@...gle.com, earny@...4u.de,
	linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	"Hugh Dickins" <hugh.dickins@...cali.co.uk>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Eric Anholt" <eric@...olt.net>, stable@...nel.org
Subject: Re: [PATCH] drm/i915: Selectively enable self-reclaim

On Thu, 28 Jan 2010 04:15:00 +0100, Michael Reinelt  
<michael@...nelt.co.at> wrote:

>
>
> Pekka Enberg schrieb:
>> Chris Wilson kirjoitti:
>>> Having missed the ENOMEM return via i915_gem_fault(), there are  
>>> probably
>>> other paths that I also missed. By not enabling NORETRY by default  
>>> these
>>> paths can run the shrinker and take memory from the system (but not  
>>> from
>>> our own inactive lists because our shrinker can not run whilst we hold
>>> the struct mutex) and this may allow the system to survive a little
>>> longer
>>> whilst our drivers consume all available memory.
>>>
>>> References:
>>>   OOM killer unexpectedly called with kernel 2.6.32
>>>   http://bugzilla.kernel.org/show_bug.cgi?id=14933
>>>
>>> Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
>>> Cc: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>>> Cc: Hugh Dickins <hugh.dickins@...cali.co.uk>
>>> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
>>> Cc: Eric Anholt <eric@...olt.net>
>>> Cc: stable@...nel.org
>>
>> Roman, can you give this patch a spin?
>
> Applied to 2.6.33-rc5, stress-test under heavy load, no problem so far.  
> Looks fine!

Here it works too, thanks!

Roman

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/