linux-kernel - Re: bio too big - in nested raid setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100129091457.0088c4af@notabene>
Date:	Fri, 29 Jan 2010 09:14:57 +1100
From:	Neil Brown <neilb@...e.de>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	"Ing. Daniel Rozsnyó" <daniel@...snyo.com>,
	Milan Broz <mbroz@...hat.com>,
	Marti Raudsepp <marti@...fo.org>, linux-kernel@...r.kernel.org,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: bio too big - in nested raid setup

On Thu, 28 Jan 2010 14:07:31 +0200
Boaz Harrosh <bharrosh@...asas.com> wrote:

> On 01/28/2010 12:50 PM, Neil Brown wrote:
> > 
> > Both raid0 and linear register a 'bvec_mergeable' function (or whatever it is
> > called today).
> > This allows for the fact that these devices have restrictions that cannot be
> > expressed simply with request sizes.  In particular they only handle requests
> > that don't cross a chunk boundary.
> > 
> > As raid1 never calls the bvec_mergeable function of it's components (it would
> > be very hard to get that to work reliably, maybe impossible), it treats any
> > device with a bvec_mergeable function as though the max_sectors were one page.
> > This is because the interface guarantees that a one page request will always
> > be handled.
> > 
> 
> I'm also guilty of doing some mirror work, in exofs, over osd objects.
> 
> I was thinking about that reliability problem with mirrors, also related
> to that infamous problem of coping the mirrored buffers so they do not
> change while writing at the page cache level.

So this is a totally new topic, right?

> 
> So what if we don't fight it? what if we just keep a journal of the mirror
> unbalanced state and do not page_uptodate until the mirror is finally balanced.
> Only then pages can be dropped from the cache, and journal cleared.

I cannot see what you are suggesting, but it seems like a layering violation.
The block device level cannot see anything about whether the page is up to
date or not.  The page it has may not even be in the page cache.

The only thing that the block device can do is make a copy of the page and
write that out twice.

If we could have a flag which the filesystem can send to say "I promise not
to change this page until the IO completes", then that copy could be
optimised away in lots of common cases.


> 
> (Balanced-mirror-page is when a page has participated in an IO to all devices
>  without being marked dirty from the get-go to the completion of IO)
> 

Block device cannot see the 'dirty' flag.


> I think Trond's last work with adding that un_updated-but-committed state to
> pages can facilitate in doing that, though I do understand that it is a major
> conceptual change to the the VFS-BLOCKS relationship in letting the block devices
> participate in the pages state machine (And md keeping a journal). Sigh
> 
> ??
> Boaz

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/