lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100128042338.GA7004@kroah.com>
Date:	Wed, 27 Jan 2010 20:23:38 -0800
From:	Greg KH <greg@...ah.com>
To:	Nitin Gupta <ngupta@...are.org>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3][resend] set block size to PAGE_SIZE and some
	cleanups

On Thu, Jan 28, 2010 at 09:29:34AM +0530, Nitin Gupta wrote:
> [replace stat_*() with rzs_stat*()]
> ---
> 
> ramzswap block size needs to be set to PAGE_SIZE
> to avoid receiving any unaligned block I/O (happens
> during swapon time). These unaligned access produce
> unncessary I/O errors, scaring users.
> 
> Also included some minor cleanups.

Such as?

Could you break this into 2 patches, one the block size stuff, and the
other the cleanups?  Remember, 1 patch does 1 thing.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ