linux-kernel - Re: [PATCH] power_supply: Clean up wm97xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001291111.11133.marek.vasut@gmail.com>
Date:	Fri, 29 Jan 2010 11:11:11 +0100
From:	Marek Vasut <marek.vasut@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Anton Vorontsov <avorontsov@...mvista.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power_supply: Clean up wm97xx_battery warnings

Dne St 27. ledna 2010 21:45:35 Mark Brown napsal(a):
> Staticise work_lock (nothing outside the driver has any reason to
> see it) and specify dev when requesting the charger IRQ (since that's
> what we pass in when we free it).
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Hi, thanks.

Acked-by: Marek Vasut <marek.vasut@...il.com>

> ---
>  drivers/power/wm97xx_battery.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/wm97xx_battery.c
>  b/drivers/power/wm97xx_battery.c index 6ea3cb5..23eed35 100644
> --- a/drivers/power/wm97xx_battery.c
> +++ b/drivers/power/wm97xx_battery.c
> @@ -26,7 +26,7 @@
> 
>  static DEFINE_MUTEX(bat_lock);
>  static struct work_struct bat_work;
> -struct mutex work_lock;
> +static struct mutex work_lock;
>  static int bat_status = POWER_SUPPLY_STATUS_UNKNOWN;
>  static struct wm97xx_batt_info *gpdata;
>  static enum power_supply_property *prop;
> @@ -203,7 +203,7 @@ static int __devinit wm97xx_bat_probe(struct
>  platform_device *dev) goto err2;
>  		ret = request_irq(gpio_to_irq(pdata->charge_gpio),
>  				wm97xx_chrg_irq, IRQF_DISABLED,
> -				"AC Detect", 0);
> +				"AC Detect", dev);
>  		if (ret)
>  			goto err2;
>  		props++;	/* POWER_SUPPLY_PROP_STATUS */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/