linux-kernel - Re: [PATCH v3] port ricoh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100129181857.1f23f013@fido2.homeip.net>
Date:	Fri, 29 Jan 2010 18:18:57 -0800
From:	Philip Langdale <philipl@...rt.org>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	Wolfram Sang <w.sang@...gutronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pierre Ossman <pierre@...man.eu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH v3] port ricoh_mmc to pci quirk

On Sat, 30 Jan 2010 00:10:33 +0200
Maxim Levitsky <maximlevitsky@...il.com> wrote:

> Well, I have nothing against this, but, even Linus himself stated that
> he dislikes broken printk lines.
> 
> I also noticed that some DECLARE_FIXUP in this file are longer that
> 80, and since breaking this doesn't add any value, I thought that is
> ok. Remember that main purpose of 80 char limit is to make code
> simpler.
> 
> However, I don't really care if you insist.

I don't want to be obnoxious either - if no one else is concerned about
the lines, I won't kick up a fuss.

And thanks for sticking with this patch - I want to see it in soon too;
I'd like to sort out the new PCI-e Ricoh parts which are going to need
a new magic sequence.

--phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/