linux-kernel - Re: [PATCH] virtio_blk: add block topology support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001301529.49848.rusty@rustcorp.com.au>
Date:	Sat, 30 Jan 2010 15:29:49 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Christoph Hellwig <hch@....de>
Cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio_blk: add block topology support

On Sat, 30 Jan 2010 05:31:58 am Christoph Hellwig wrote:
> Allow reading various alignment values from the config page.  This
> allows the guest to much better align I/O requests depending on the
> storage topology.
> 
> Note that the formats for the config values appear a bit messed up,
> but we follow the formats used by ATA and SCSI so they are expected in
> the storage world.

I bow to your expertise on that.  My only query is the __u16 for min_io_size; is that likely to restrict us?

Also, patch seems to be based on a prior one?

>  	/* Use topology information if available */
> -	err = virtio_config_val(vdev, VIRTIO_BLK_F_BLK_TOPOLOGY,
> +	err = virtio_config_val(vdev, VIRTIO_BLK_F_TOPOLOGY,
> +			offsetof(struct virtio_blk_config, physical_block_exp),
> +			&physical_block_exp);

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/