linux-kernel - Re: [PATCH 0/3] HID: make raw output callback more flexible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iqakifm8.fsf@troilus.org>
Date:	Fri, 29 Jan 2010 19:46:39 -0500
From:	Michael Poole <mdpoole@...ilus.org>
To:	Bastien Nocera <hadess@...ess.net>,
	Marcel Holtmann <marcel@...tmann.org>
Cc:	Jiri Kosina <jkosina@...e.cz>, "Gunn\, Brian" <bgunn@...ekai.com>,
	Ping <pinglinux@...il.com>, linux-kernel@...r.kernel.org,
	BlueZ development <linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH 0/3] HID: make raw output callback more flexible

Bastien Nocera writes:

> On Fri, 2010-01-29 at 15:20 +0100, Jiri Kosina wrote:
>> Hi,
>> 
>> this is a followup to the thread
>> 
>> 	"Implement Bluetooth Wacom tablet's mode change in the kernel"
>> 
>> First patch alters the raw output API so that it is able to actually 
>> distinguish between feature and output reports (and modifies low-level 
>> drivers accordingly), and the two followup patches make use of this for 
>> in-kernel mode setting of Sony and Wacom bluetooth devices.
>> 
>> Marcel, could you please review the Bluetooth part?

Count this as another vote for review, please -- I have a similar
patch[1] that I would prefer to drop.

[1]- http://www.spinics.net/lists/linux-input/msg06768.html

> Patches 1 and 2 work as expected (minus the hidp parsing issue[1]).
> Couldn't test patch 3 for the Sony Sixaxis right now.
>
> Cheers
>
> [1]: Comments on the patch at
> http://thread.gmane.org/gmane.linux.bluez.kernel/4279 would be
> appreciated

This patch does not work for me.  Before, the first time after each boot
that I tried to connect to an Apple Magic Mouse, it failed with -14
(EFAULT).  With this patch, it fails with -22 (EINVAL) instead.  The
-EFAULT *was* due to hidp_parse()'s copy_from_user().  I have not looked
yet to see where the -EINVAL is coming from -- would that help?  (Both
with and without your patch, the second attempt to connect works.)

Michael Poole
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/