| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <69e28c911001311322v7f3bdd9v4fd2fe85b2e50d1a@mail.gmail.com>
Date: Sun, 31 Jan 2010 22:22:51 +0100
From: Gábor Stefanik <netrolller.3d@...il.com>
To: Joe Perches <joe@...ches.com>
Cc: linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 06/10] drivers/staging: Fix continuation line formats
On Sun, Jan 31, 2010 at 9:02 PM, Joe Perches <joe@...ches.com> wrote:
> String constants that are continued on subsequent lines with \
> are not good.
> Fixed a "is tryied" / tried typo
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> drivers/staging/dream/qdsp5/audio_mp3.c | 3 +--
> .../rtl8187se/ieee80211/ieee80211_softmac_wx.c | 3 +--
> drivers/staging/rtl8187se/r8180_core.c | 3 +--
> drivers/staging/sep/sep_driver.c | 3 +--
> 4 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/dream/qdsp5/audio_mp3.c b/drivers/staging/dream/qdsp5/audio_mp3.c
> index b95574f..7ed6e26 100644
> --- a/drivers/staging/dream/qdsp5/audio_mp3.c
> +++ b/drivers/staging/dream/qdsp5/audio_mp3.c
> @@ -650,8 +650,7 @@ static long audio_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> &audio->read_phys,
> GFP_KERNEL);
> if (!audio->read_data) {
> - pr_err("audio_mp3: malloc pcm \
> - buf failed\n");
> + pr_err("audio_mp3: malloc pcm buf failed\n");
> rc = -1;
> } else {
> uint8_t index;
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> index f1d6cb4..ad42bcd 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
> @@ -482,8 +482,7 @@ int ieee80211_wx_set_power(struct ieee80211_device *ieee,
> (!ieee->enter_sleep_state) ||
> (!ieee->ps_is_queue_empty)){
>
> - printk("ERROR. PS mode is tryied to be use but\
> -driver missed a callback\n\n");
> + printk("ERROR. PS mode tried to be use but driver missed a callback\n\n");
This have more typos... "to be use"?
>
> return -1;
> }
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index e0f13ef..278992a 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -3864,8 +3864,7 @@ static int __init rtl8180_pci_module_init(void)
> return ret;
> }
>
> - printk(KERN_INFO "\nLinux kernel driver for RTL8180 \
> -/ RTL8185 based WLAN cards\n");
> + printk(KERN_INFO "\nLinux kernel driver for RTL8180 / RTL8185 based WLAN cards\n");
While you are at it, change this to read RTL8187SE, since RTL8180/85
are not supported by this driver.
> printk(KERN_INFO "Copyright (c) 2004-2005, Andrea Merello\n");
> DMESG("Initializing module");
> DMESG("Wireless extensions version %d", WIRELESS_EXT);
> diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c
> index e7bc9ec..8793878 100644
> --- a/drivers/staging/sep/sep_driver.c
> +++ b/drivers/staging/sep/sep_driver.c
> @@ -380,8 +380,7 @@ static int sep_mmap(struct file *filp, struct vm_area_struct *vma)
> shared area */
> if ((vma->vm_end - vma->vm_start) > SEP_DRIVER_MMMAP_AREA_SIZE) {
> edbg("SEP Driver mmap requested size is more than allowed\n");
> - printk(KERN_WARNING "SEP Driver mmap requested size is more \
> - than allowed\n");
> + printk(KERN_WARNING "SEP Driver mmap requested size is more than allowed\n");
> printk(KERN_WARNING "SEP Driver vma->vm_end is %08lx\n", vma->vm_end);
> printk(KERN_WARNING "SEP Driver vma->vm_end is %08lx\n", vma->vm_start);
> return -EAGAIN;
> --
> 1.6.6.rc0.57.gad7a
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists