linux-kernel - Re: [Patch] net: export TCP send buffer size via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265014309.2848.7.camel@edumazet-laptop>
Date:	Mon, 01 Feb 2010 09:51:49 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [Patch] net: export TCP send buffer size via netlink

Le lundi 01 février 2010 à 02:59 -0500, Amerigo Wang a écrit :
> Currently, we can only get TCP send buffer size by
> getsockopt (SO_SNDBUF or TCP_INFO), this is not enough
> for the tools like netstat or ss to read.
> 
> Show TCP send buffer size via netlink NETLINK_INET_DIAG.
> 
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: David Miller <davem@...emloft.net>
> 
> ---
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index 7fee8a4..46768de 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -136,6 +136,7 @@ struct tcp_info {
>  	__u32	tcpi_ato;
>  	__u32	tcpi_snd_mss;
>  	__u32	tcpi_rcv_mss;
> +	__u32	tcpi_sndbuf;
>  
>  	__u32	tcpi_unacked;
>  	__u32	tcpi_sacked;

You cannot change tcp_info like this, this structure is used by some
programs, and they are going to break badly.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/