linux-kernel - Re: [PATCH] perf tools: fix write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265014573.24455.99.camel@laptop>
Date:	Mon, 01 Feb 2010 09:56:13 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf tools: fix write_event()

On Sun, 2010-01-31 at 09:32 +0100, Ingo Molnar wrote:
> * Xiao Guangrong <xiaoguangrong@...fujitsu.com> wrote:
> 
> > We parse the event while it's read from mmap buffer in
> > write_event(), but sometimes the event will straddles the
> > mmap boundary, we should handle this case
> > 
> > And if we record events(such as perf kmem/sched) for long
> > times, Ctrl + C can't interrupt it just for this reason
> > 
> > Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
> > ---
> >  tools/perf/builtin-record.c |   62 +++++++++++++++++++++++++++++++++---------
> 
> Note, i've reverted the original instead, via:
> 
>   a8e6f73: Revert "perf record: Intercept all events"
> 
> As Peter said it, it is fundamentally wrong for perf record to touch the data 
> stream in the common case. Arnaldo, cannot we use some other method for perf 
> archive's needs? Worst-case we can do an optional parsing of the data stream 
> although we should first try hard to find a generic method ...

Arnaldo posted patches for this last friday somewhere, it might turn out
you already found them (reading mail by date order here).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/