linux-kernel - Re: [Patch v2] net: export TCP send buffer size via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100201.020055.57470143.davem@davemloft.net>
Date:	Mon, 01 Feb 2010 02:00:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [Patch v2] net: export TCP send buffer size via netlink

From: Amerigo Wang <amwang@...hat.com>
Date: Mon, 1 Feb 2010 04:18:28 -0500

> V1 -> V2:
> Keep ABI compatiblity of struct tcp_info.
> 
> Currently, we can only get TCP send buffer size by
> getsockopt (SO_SNDBUF or TCP_INFO), this is not enough
> for the tools like netstat or ss to read.
> 
> Show TCP send buffer size via netlink NETLINK_INET_DIAG.
> 
> Signed-off-by: WANG Cong <amwang@...hat.com>

If the user has a "struct tcp_info info" on it's stack,
and it's compiled against the header file before your
changes, guess what the kernel is going to do?

It's going to write past the end of the user's variable
into random stack locations.

You can't change the layout, at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/