linux-kernel - Re: [PATCH 00/68] ide2libata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100201.051432.226757615.davem@davemloft.net>
Date:	Mon, 01 Feb 2010 05:14:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	alan@...rguk.ukuu.org.uk
Cc:	jeff@...zik.org, bzolnier@...il.com, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/68] ide2libata

From: Alan Cox <alan@...rguk.ukuu.org.uk>
Date: Mon, 1 Feb 2010 12:58:45 +0000

>> > The old drivers contain a fair amount of crap, magic and gueswork so a
>> > good deal of human analysis and testing is needed to move any change
>> > around and prove it's real and valid not guesswork and fudging.
>> 
>> And then once that hard work is done, we kind of just toss it
>> for one side of the equation?
> 
> I don't where you got that idea from.
> 
> The "merge" makes it harder to maintain both, adds lots of ifdefs and
> artificial divisions of code stuffed into include files. Its ugly as sin
> and makes *both* sets of drivers harder to maintain.

I have not advocated the ifdef implementation.

I have advocated one where the data structures are actually
the same, and there are no ifdefs.

Please reread my initial reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/