linux-kernel - Re: [REPORT] may be wrong place #endif in include/linux/netfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B66DE62.8080801@trash.net>
Date:	Mon, 01 Feb 2010 15:00:02 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Jan Engelhardt <jengelh@...ozas.de>
CC:	"Helight.Xu" <helight.xu@...il.com>, netfilter@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org
Subject: Re: [REPORT] may be wrong place #endif in include/linux/netfilter_ipv4.h

Jan Engelhardt wrote:
> On Sunday 2010-01-31 03:13, Helight.Xu wrote:
> 
>> hi all gys:
>>
>>   when I make LKM with netfilter on "NF_IP_PRE_ROUTING" point, but it was
>> reported that "NF_IP_PRE_ROUTING" is not defined.
>>
>>   but I am surely including <linux/netfilter_ipv4.h>, when I opened
>> include/linux/netfilter_ipv4.h I found that
>> "NF_IP_PRE_ROUTING" is in this lable :
>> #ifndef __KERNEL__
>> .....
>> /* IP Hooks */
>> /* After promisc drops, checksum checks. */
>> #define NF_IP_PRE_ROUTING       0
>> /* If the packet is destined for this box. */
>> #define NF_IP_LOCAL_IN          1
>> /* If the packet is destined for another interface. */
>> #define NF_IP_FORWARD           2
>> /* Packets coming from a local process. */
>> #define NF_IP_LOCAL_OUT         3
>> /* Packets about to hit the wire. */
>> #define NF_IP_POST_ROUTING      4
>> #define NF_IP_NUMHOOKS          5
>> #endif /* ! __KERNEL__ */
>>
>> So I think the "endif" is ended a little early!
> 
> Seems so. Are there any out-of-tree nf_ip_hook_priorities users? If not, 
> we could possibly move it further below.

Its only available for userspace for compatibility reasons,
the kernel doesn't use the old definitions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/