linux-kernel - Re: [PATCH v8] RO/NX protection for loadable kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <817ecb6f1002010822j769ccda6wfc39c0dbd42420cd@mail.gmail.com>
Date:	Mon, 1 Feb 2010 11:22:45 -0500
From:	Siarhei Liakh <sliakh.lkml@...il.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-next@...r.kernel.org,
	Arjan van de Ven <arjan@...radead.org>,
	James Morris <jmorris@...ei.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@....de>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Dave Jones <davej@...hat.com>
Subject: Re: [PATCH v8] RO/NX protection for loadable kernel modules

> Needs more brackets around arguments, otherwise someone calling it with
> a complex expression will get very upset.
[...]

Done.

> The core_text_size test should be enough here.

Done.

>> +                     begin_pfn = PFN_DOWN((unsigned long)mod->module_core);
>> +                     end_pfn = PFN_DOWN((unsigned long)mod->module_core +
>> +                                             mod->core_text_size);
>> +                     if (end_pfn > begin_pfn)
>> +                             set_memory_rw(begin_pfn << PAGE_SHIFT,
>> +                                                     end_pfn - begin_pfn);
>
> Much of this code might be neater if you created a helper:

Done.

> But these are minor: patch looks good!

Thanks for your feedback!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/