lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 1 Feb 2010 11:22:45 -0500
From:	Siarhei Liakh <>
To:	Rusty Russell <>
	Arjan van de Ven <>,
	James Morris <>,
	Andrew Morton <>,
	Andi Kleen <>, Thomas Gleixner <>,
	"H. Peter Anvin" <>, Ingo Molnar <>,
	Stephen Rothwell <>,
	Dave Jones <>
Subject: Re: [PATCH v8] RO/NX protection for loadable kernel modules

> Needs more brackets around arguments, otherwise someone calling it with
> a complex expression will get very upset.


> The core_text_size test should be enough here.


>> +                     begin_pfn = PFN_DOWN((unsigned long)mod->module_core);
>> +                     end_pfn = PFN_DOWN((unsigned long)mod->module_core +
>> +                                             mod->core_text_size);
>> +                     if (end_pfn > begin_pfn)
>> +                             set_memory_rw(begin_pfn << PAGE_SHIFT,
>> +                                                     end_pfn - begin_pfn);
> Much of this code might be neater if you created a helper:


> But these are minor: patch looks good!

Thanks for your feedback!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists