| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1265045422.25140.289.camel@Joe-Laptop.home> Date: Mon, 01 Feb 2010 09:30:22 -0800 From: Joe Perches <joe@...ches.com> To: James Bottomley <James.Bottomley@...e.de> Cc: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats On Mon, 2010-02-01 at 11:16 -0600, James Bottomley wrote: > On Sun, 2010-01-31 at 12:02 -0800, Joe Perches wrote: > > String constants that are continued on subsequent lines with \ > > are not good. > > Why? It's perfectly valid ansi C. Because they generally add unwanted spaces or tabs between words in logging messages. Just like these do. > but I also dislike your solution; I'd have split the string into two > separate ones and relied on compiler concatenation. Which Linus dislikes because it makes grepping difficult. > However, the point is that all three are perfectly legal C. Choosing > one form over another is something best left to the maintainers rather > than imposing one style by fiat. Which a patch does not do. > Consider this change veto'd unless you can get an explicit ack from the > current maintainer for changing their style. The current messages are defective. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists