linux-kernel - Re: [PATCH] Constify struct mtrr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B6726AA.4000009@zytor.com>
Date:	Mon, 01 Feb 2010 11:08:26 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Emese Revfy <re.emese@...il.com>
CC:	mingo@...hat.com, tglx@...utronix.de,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Constify struct mtrr_ops for v2.6.33-rc6

On 01/31/2010 11:16 AM, Emese Revfy wrote:
> From: Emese Revfy <re.emese@...il.com>
> 
> Constify struct mtrr_ops.
> 
> This is part of the ops structure constification
> effort started by Arjan van de Ven et al.
> 
> Benefits of this constification:
> 
>  * prevents modification of data that is shared
>    (referenced) by many other structure instances
>    at runtime
> 
>  * detects/prevents accidental (but not intentional)
>    modification attempts on archs that enforce
>    read-only kernel data at runtime
> 
>  * potentially better optimized code as the compiler
>    can assume that the const data cannot be changed
> 
>  * the compiler/linker move const data into .rodata
>    and therefore exclude them from false sharing
> 
> Signed-off-by: Emese Revfy <re.emese@...il.com>
> Acked-by: H. Peter Anvin <hpa@...or.com>

Yes, but this doesn't exactly seem like 2.6.33 matter.  I will put it in
-tip for 2.6.34.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/