linux-kernel - Possible NULL pointer dereference in m32r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100201213635.GA24391@steve.org.uk>
Date:	Mon, 1 Feb 2010 21:36:35 +0000
From:	Steve Kemp <kernel@...ve.org.uk>
To:	linux-kernel@...r.kernel.org
Subject: Possible NULL pointer dereference in m32r

   arch/m32r/kernel/smp.c contains the following code:

--
    preempt_disable();
    cpu_id = smp_processor_id();
    mmc = &mm->context[cpu_id];
    cpu_mask = mm->cpu_vm_mask;
    cpu_clear(cpu_id, cpu_mask);

#iffdef DEBUG_SMP
   if (!mm)
       BUG();
#endif
--

  mm might be NULL, but this would only be detected after it
 has been dereferenced, and only then if DEBUG_SMP is defined.

  I'd suggest changing to read something like this:

--
    if ( !mm )
        BUG();

    preempt_disable();
--

Steve
--
http://www.steve.org.uk/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/