linux-kernel - Re: [PATCH 1/6] generic sys_old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m24om0shpe.fsf@igel.home>
Date:	Mon, 01 Feb 2010 23:40:29 +0100
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Christoph Hellwig <hch@....de>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, linux@....linux.org.uk,
	dhowells@...hat.com, ysato@...rs.sourceforge.jp,
	tony.luck@...el.com, geert@...ux-m68k.org, zippel@...ux-m68k.org,
	gerg@...inux.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, jdike@...toit.com, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, viro@...iv.linux.org.uk
Subject: Re: [PATCH 1/6] generic sys_old_select

Christoph Hellwig <hch@....de> writes:

> Index: linux-2.6/fs/compat.c
> ===================================================================
> --- linux-2.6.orig/fs/compat.c	2010-01-12 14:08:16.202003005 +0100
> +++ linux-2.6/fs/compat.c	2010-01-29 23:35:20.187003404 +0100
> @@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
>  	return ret;
>  }
>  
> +struct compat_sel_arg_struct {
> +	compat_ulong_t n;
> +	compat_ulong_t inp;
> +	compat_ulong_t outp;
> +	compat_ulong_t exp;
> +	compat_ulong_t tvp;
> +};

Shouldn't the last four be compat_uptr_t?

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/