lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 02 Feb 2010 18:16:30 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Patrick McHardy <kaber@...sh.net> Cc: Jon Masters <jonathan@...masters.org>, Alexey Dobriyan <adobriyan@...il.com>, linux-kernel <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, netfilter-devel <netfilter-devel@...r.kernel.org>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> Subject: Re: PROBLEM with summary: Re: [PATCH] netfilter: per netns nf_conntrack_cachep Le mardi 02 février 2010 à 18:04 +0100, Patrick McHardy a écrit : > Ah nice catch, that seems to be the problem. When the untracked > conntrack is already attached to an skb and thus has refcnt > 1 > and we re-initalize the refcnt, it will get freed. > > The question is whether the ct_net pointer of the untracked conntrack > is actually required. If so, we need one instance per namespace, > otherwise we can just move initialization and cleanup to the init_net > init/cleanup functions. Alexey, do you happen to know this? > One untracked per netns seems the way to go, and move it outside of read_mostly area too, we obviously can modify its refcount frequently... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists