linux-kernel - Re: [PATCH] qla2xxx: negative error return in qla2x00_change_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2010 11:47:47 -0800
From:	Giridhar Malavali <giridhar.malavali@...gic.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Vasquez <andrew.vasquez@...gic.com>,
	Linux Driver <Linux-Driver@...gic.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth()

Acked-by: Giridhar Malavali <giridhar.malavali@...gic.com>

On Jan 29, 2010, at 2:25 AM, Roel Kluin wrote:

> The *change_queue_depth functions usually return a negative error  
> return.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/ 
> qla_os.c
> index 8529eb1..0753877 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device  
> *sdev, int qdepth, int reason)
> 		qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
> 		break;
> 	default:
> -		return EOPNOTSUPP;
> +		return -EOPNOTSUPP;
> 	}
>
> 	return sdev->queue_depth;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/