linux-kernel - Re: [PATCH 1/14] move user_enable_single_step & co prototypes to linux/ptrace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a1002030042t5cdc1a88oe9e273e7d6ec4269@mail.gmail.com>
Date:	Wed, 3 Feb 2010 03:42:05 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Christoph Hellwig <hch@....de>
Cc:	roland@...hat.com, oleg@...hat.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	mattst88@...il.com, ink@...assic.park.msu.ru, rth@...ddle.net,
	linux@....linux.org.uk, hskinnemoen@...el.com, vapier@...too.org,
	starvik@...s.com, jesper.nilsson@...s.com,
	ysato@...rs.sourceforge.jp, takata@...ux-m32r.org,
	gerg@...inux.org, monstr@...str.eu, ralf@...ux-mips.org,
	jdike@...toit.com, chris@...kel.net
Subject: Re: [PATCH 1/14] move user_enable_single_step & co prototypes to 
	linux/ptrace.h

On Tue, Feb 2, 2010 at 13:57, Christoph Hellwig wrote:
> While in theory user_enable_single_step/user_disable_single_step/
> user_enable_blockstep could also be provided as an inline or macro there's no
> good reason to do so, and having the prototype in one places keeps code size
> and confusion down.

the only annoying thing here is that we currently have to enable both
user_disable_single_step() and ptrace_disable() that do exactly the
same thing.  i avoided this somewhat on Blackfin by cheating:
#define user_disable_single_step(child) ptrace_disable(child)

so now there's no code bloat.  perhaps this could be moved into common
linux/ptrace.h too ?

> --- linux-2.6/include/linux/ptrace.h
> +++ linux-2.6/include/linux/ptrace.h
> @@ -238,6 +238,9 @@
>  static inline void user_disable_single_step(struct task_struct *task)
>  {
>  }
> +#else
> +extern void user_enable_single_step(struct task_struct *);
> +extern void user_disable_single_step(struct task_struct *);
>  #endif /* arch_has_single_step */

+#define ptrace_disable(child) user_disable_single_step(child)
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/