linux-kernel - Re: [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2010 06:17:30 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Bastien Nocera <hadess@...ess.net>,
	Michael Poole <mdpoole@...ilus.org>,
	"Gunn, Brian" <bgunn@...ekai.com>, Ping <pinglinux@...il.com>,
	linux-kernel@...r.kernel.org,
	BlueZ development <linux-bluetooth@...r.kernel.org>
Subject: Re: [PATCH 3/3] HID: Enable Sixaxis controller over Bluetooth

Hi Jiri,

> Now that hid_output_raw_report works, port the PS3 Sixaxis
> Bluetooth quirk from user-space, into kernel-space.
> 
> Signed-off-by: Bastien Nocera <hadess@...ess.net>
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Acked-by: Marcel Holtmann <marcel@...tmann.org>
 
> -	ret = sony_set_operational(hdev);
> +	if (hdev->bus == BUS_USB)
> +		ret = sony_set_operational(hdev);
> +	else if (hdev->bus == BUS_BLUETOOTH)
> +		ret = sony_set_operational_bt(hdev);
> +	else
> +		ret = 0;
> +

I would do sony_set_operational_usb() and sony_set_operational_bt() and
also turn this into a switch statement for better readability.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/