linux-kernel - Re: [PATCH] seastar - SeaStar Ethernet driver (review comments addressed)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100202180757.51078dad@nehalam>
Date:	Tue, 2 Feb 2010 18:07:57 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Kevin Pedretti <ktpedre@...dia.gov>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] seastar - SeaStar Ethernet driver (review comments
 addressed)

On Tue, 02 Feb 2010 18:02:01 -0800
Joe Perches <joe@...ches.com> wrote:

> Presumably SeaStar doesn't support multicast either, so maybe:
> 	if (dest_low_mac & 0x01)

Why not:
        if (is_multicast_ether_addr(ethdr->h_dest))
...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/