linux-kernel - Re: [PATCHv2 05/11] mxc: Core support for i.MX5 series of processors from Freescale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100203160835.GA1928@debian>
Date:	Wed, 3 Feb 2010 21:38:36 +0530
From:	Rabin Vincent <rabin@....in>
To:	Amit Kucheria <amit.kucheria@...onical.com>
Cc:	List Linux Kernel <linux-kernel@...r.kernel.org>,
	linux@....linux.org.uk, Dinh.Nguyen@...escale.com,
	s.hauer@...gutronix.de, grant.likely@...retlab.ca,
	r.herring@...escale.com, linux-arm-kernel@...ts.infradead.org,
	daniel@...aq.de, bryan.wu@...onical.com, valentin.longchamp@...l.ch
Subject: Re: [PATCHv2 05/11] mxc: Core support for i.MX5 series of
 processors from Freescale

On Tue, Feb 02, 2010 at 09:16:27PM -0800, Amit Kucheria wrote:
> diff --git a/arch/arm/mach-mx5/clock.c b/arch/arm/mach-mx5/clock.c
[...]
> +static struct clk_lookup lookups[] __initdata = {
> +	_REGISTER_CLOCK("imx-uart.0", NULL, uart1_clk)
> +	_REGISTER_CLOCK("imx-uart.1", NULL, uart2_clk)
> +	_REGISTER_CLOCK("imx-uart.2", NULL, uart3_clk)
> +	_REGISTER_CLOCK(NULL, "gpt", gpt_clk)
> +	_REGISTER_CLOCK("fec.0", NULL, fec_clk)
> +};

This shouldn't be __initdata.  clk_get() uses this, and modules may use
clk_get().

Rabin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/