linux-kernel - Re: [PATCH 3/3] kernel-shark: fix unitialized handle compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265213851.24386.1.camel@gandalf.stny.rr.com>
Date:	Wed, 03 Feb 2010 11:17:31 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	John Kacur <jkacur@...hat.com>
Cc:	Darren Hart <dvhltc@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] kernel-shark: fix unitialized handle compile
 warnings

On Wed, 2010-02-03 at 17:05 +0100, John Kacur wrote:
> On Mon, Feb 1, 2010 at 5:50 PM, Darren Hart <dvhltc@...ibm.com> wrote:
> > Signed-off-by: Darren Hart <dvhltc@...ibm.com>
> > ---
> >  kernel-shark.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel-shark.c b/kernel-shark.c
> > index 9dedf48..222381c 100644
> > --- a/kernel-shark.c
> > +++ b/kernel-shark.c
> > @@ -596,10 +596,10 @@ void kernel_shark(int argc, char **argv)
> >                if (ret >= 0)
> >                        input_file = default_input_file;
> >        }
> > -       if (handle)
> > -               handle = tracecmd_open(input_file);
> > +       handle = tracecmd_open(input_file);
> >
> > -       info->handle = handle;
> > +       if (handle)
> > +               info->handle = handle;
> >
> >        /* --- Main window --- */
> >
> > --
> 
> This looks correct, but I'm wondering if it is safe to continue if the
> call to tracecmd_open fails?

Actually this patch is wrong. The real code should be:

-	if (handle)
+	if (input_file)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/