linux-kernel - Re: [PATCHv2 02/11] mxc timer: refactor timer code to use timer versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa41002030823r7ebf0ee5l156ffafb57a8d5d2@mail.gmail.com>
Date:	Wed, 3 Feb 2010 09:23:18 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Amit Kucheria <amit.kucheria@...onical.com>
Cc:	List Linux Kernel <linux-kernel@...r.kernel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	valentin.longchamp@...l.ch, daniel@...aq.de,
	Dinh.Nguyen@...escale.com, r.herring@...escale.com,
	bryan.wu@...onical.com
Subject: Re: [PATCHv2 02/11] mxc timer: refactor timer code to use timer 
	versions

On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
<amit.kucheria@...onical.com> wrote:
> From: Sascha Hauer <s.hauer@...gutronix.de>
>
> Refactor the timer code into version 1 and version 2.
>
> Essentially there are 2 versions of the timer hardware. Version 1 is found on
> MX1/MXL and MX21. Version 2 is found on MX25, MX27, MX31, MX35, MX37, MX51,
> and future parts.
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Acked-by: Amit Kucheria <amit.kucheria@...onical.com>
> Signed-off-by: Amit Kucheria <amit.kucheria@...onical.com>
> ---
>  arch/arm/plat-mxc/time.c |   19 +++++++++++--------
>  1 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/time.c b/arch/arm/plat-mxc/time.c
> index 844567e..7d6499e 100644
> --- a/arch/arm/plat-mxc/time.c
> +++ b/arch/arm/plat-mxc/time.c
> @@ -57,6 +57,9 @@
>  #define MX3_TCN                        0x24
>  #define MX3_TCMP               0x10
>
> +#define timer_is_v1()  (cpu_is_mx1() || cpu_is_mx27())
> +#define timer_is_v2()  (cpu_is_mx3() || cpu_is_mx25())

Just from a defensive programming standpoint, it may be better to
define timer_is_v2() as (!timer_is_v1()).  I assume future parts are
more likely to be v2, and doing it that way means one less place in
the code to modify when new parts appear.

Otherwise,
Acked-by: Grant Likely <grant.likely@...retlab.ca>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/