linux-kernel - Re: linux-next: driver-core tree build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2010 18:22:47 -0800
From:	Greg KH <greg@...ah.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: linux-next: driver-core tree build warning

On Fri, Jan 29, 2010 at 06:21:15PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Thu, 21 Jan 2010 15:10:10 -0800 Greg KH <greg@...ah.com> wrote:
> >
> > Here's a patch that I just applied to my tree to hopefully resolve this
> > issue.
> 
> I still get the warnings.
> 
> > -static CLASS_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
> > -static CLASS_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> > +static SYSDEV_ATTR(probe, S_IWUSR, NULL, cpu_probe_store);
> 
> This defines attr_probe as a "struct sysdev_attribute" whose attr element
> is a "struct attribute".
> 
> > +static SYSDEV_ATTR(release, S_IWUSR, NULL, cpu_release_store);
> >  #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */
> >  
> >  #else /* ... !CONFIG_HOTPLUG_CPU */
> > @@ -261,8 +261,8 @@ int __init cpu_dev_init(void)
> >  
> >  static struct sysdev_class_attribute *cpu_sysdev_class_attrs[] = {
> >  #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> > -	&class_attr_probe.attr,
> > -	&class_attr_release.attr,
> > +	&attr_probe.attr,
> 
> so here we are initialising a "struct sysdev_class_attribute *" with a
> "struct attribute *".  Thus the warning.

Doh, sorry about that.  I've fixed it up now and pushed it out.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/